Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Change uTwin version to v2 #111

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Change uTwin version to v2 #111

merged 1 commit into from
Mar 15, 2024

Conversation

stevenhartley
Copy link
Contributor

The uProtocol 1.3.6 version that uses CloudEvents will be v1 so the Eclipse version that uses UMessage MUST be v2 to follow semver requirements.

#110

The uProtocol 1.3.6 version that uses CloudEvents will be v1 so the Eclipse version that uses UMessage MUST be v2 to follow semver requirements.

#110
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I understand correctly, but if the incompatible change is in the UMessage type, shouldn't there be a uprotocol.v2.UMessage being used in the service methods?

@stevenhartley
Copy link
Contributor Author

I am not sure if I understand correctly, but if the incompatible change is in the UMessage type, shouldn't there be a uprotocol.v2.UMessage being used in the service methods?

As explained on the call, this was to move v1 to GM internal repo as the original version of uTwin passed io.cloudevents.v1.CloudEvent and v2 is uprotocol.v1.UMessage

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you know what you are doing, this LGTM :-)

Copy link

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar disclaimer that Steven knows what he's doing =^)

@stevenhartley stevenhartley removed the request for review from frankghe March 15, 2024 00:52
@stevenhartley stevenhartley merged commit 5393623 into main Mar 15, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants